From dba87ca99ee9ca0093ab4f308f4df45ebc7e4c11 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mike=20F=C3=A4hrmann?= Date: Tue, 12 May 2020 20:13:04 +0200 Subject: [PATCH] [downloader:ytdl] change 'forward-cookies' default to 'false' There are currently no situations where forwarding gallery-dl's cookies to youtube-dl is necessary, and it only causes problems when forcing youtube-dl for Twitter video downloads while logged in. --- docs/configuration.rst | 2 +- docs/gallery-dl.conf | 2 +- gallery_dl/downloader/ytdl.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/configuration.rst b/docs/configuration.rst index f132a093..0efeaa76 100644 --- a/docs/configuration.rst +++ b/docs/configuration.rst @@ -1402,7 +1402,7 @@ downloader.ytdl.forward-cookies ------------------------------- =========== ===== Type ``bool`` -Default ``true`` +Default ``false`` Description Forward cookies to youtube-dl. =========== ===== diff --git a/docs/gallery-dl.conf b/docs/gallery-dl.conf index 607a1357..22646bcf 100644 --- a/docs/gallery-dl.conf +++ b/docs/gallery-dl.conf @@ -196,7 +196,7 @@ "ytdl": { "format": null, - "forward-cookies": true, + "forward-cookies": false, "mtime": true, "outtmpl": null, "rate": null, diff --git a/gallery_dl/downloader/ytdl.py b/gallery_dl/downloader/ytdl.py index fe6c4bc5..8e60a0c5 100644 --- a/gallery_dl/downloader/ytdl.py +++ b/gallery_dl/downloader/ytdl.py @@ -1,6 +1,6 @@ # -*- coding: utf-8 -*- -# Copyright 2018 Mike Fährmann +# Copyright 2018-2020 Mike Fährmann # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License version 2 as @@ -35,7 +35,7 @@ class YoutubeDLDownloader(DownloaderBase): if self.config("logging", True): options["logger"] = self.log - self.forward_cookies = self.config("forward-cookies", True) + self.forward_cookies = self.config("forward-cookies", False) outtmpl = self.config("outtmpl") self.outtmpl = DEFAULT_OUTTMPL if outtmpl == "default" else outtmpl