From c0e2ba37c828dc5d34cbdb366f48b721e645f5b5 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Sun, 19 Nov 2023 17:02:46 +0200 Subject: [PATCH] changelog, small fix --- changelog.d/double-notifications.fix | 1 + changelog.d/focus-clear.add | 1 + changelog.d/mobile-chrome-notifs.fix | 1 + changelog.d/mobile-drawer-notifications.change | 1 + changelog.d/more-notification-types-setting.fix | 1 + changelog.d/native-filtering.add | 1 + changelog.d/native-notifications.add | 1 + changelog.d/noninteractive-ignore-read.add | 1 + changelog.d/notification-read.add | 1 + changelog.d/notifications-sorting.change | 1 + changelog.d/serviceworkers.change | 1 + src/components/mobile_nav/mobile_nav.js | 3 +-- 12 files changed, 12 insertions(+), 2 deletions(-) create mode 100644 changelog.d/double-notifications.fix create mode 100644 changelog.d/focus-clear.add create mode 100644 changelog.d/mobile-chrome-notifs.fix create mode 100644 changelog.d/mobile-drawer-notifications.change create mode 100644 changelog.d/more-notification-types-setting.fix create mode 100644 changelog.d/native-filtering.add create mode 100644 changelog.d/native-notifications.add create mode 100644 changelog.d/noninteractive-ignore-read.add create mode 100644 changelog.d/notification-read.add create mode 100644 changelog.d/notifications-sorting.change create mode 100644 changelog.d/serviceworkers.change diff --git a/changelog.d/double-notifications.fix b/changelog.d/double-notifications.fix new file mode 100644 index 0000000000..24e08c0ffd --- /dev/null +++ b/changelog.d/double-notifications.fix @@ -0,0 +1 @@ +Fix native notifications appearing as many times as there are open tabs. Clicking on notification will focus last focused tab. diff --git a/changelog.d/focus-clear.add b/changelog.d/focus-clear.add new file mode 100644 index 0000000000..70f54ab69b --- /dev/null +++ b/changelog.d/focus-clear.add @@ -0,0 +1 @@ +Focusing into a tab clears all current desktop notifications diff --git a/changelog.d/mobile-chrome-notifs.fix b/changelog.d/mobile-chrome-notifs.fix new file mode 100644 index 0000000000..7db10c56a0 --- /dev/null +++ b/changelog.d/mobile-chrome-notifs.fix @@ -0,0 +1 @@ +Fixed error that appeared on mobile Chrome(ium) (and derivatives) when native notifications are allowed diff --git a/changelog.d/mobile-drawer-notifications.change b/changelog.d/mobile-drawer-notifications.change new file mode 100644 index 0000000000..9353c709dd --- /dev/null +++ b/changelog.d/mobile-drawer-notifications.change @@ -0,0 +1 @@ +Added option to not mark all notifications when closing notifications drawer on mobile, this creates a new button to mark all as seen. diff --git a/changelog.d/more-notification-types-setting.fix b/changelog.d/more-notification-types-setting.fix new file mode 100644 index 0000000000..2d71b59933 --- /dev/null +++ b/changelog.d/more-notification-types-setting.fix @@ -0,0 +1 @@ +Fixed being unable to set notification visibility for reports and follow requests diff --git a/changelog.d/native-filtering.add b/changelog.d/native-filtering.add new file mode 100644 index 0000000000..82ab9a23a0 --- /dev/null +++ b/changelog.d/native-filtering.add @@ -0,0 +1 @@ +Added option to toggle what notification types appear in native notifications, by default less important ones (likes, repeats, etc) will no longer show up in native notifications. diff --git a/changelog.d/native-notifications.add b/changelog.d/native-notifications.add new file mode 100644 index 0000000000..d896e7c04a --- /dev/null +++ b/changelog.d/native-notifications.add @@ -0,0 +1 @@ +Native notifications now also have "badge" property that matches instance's favicon (visible in Android Chromium at least) diff --git a/changelog.d/noninteractive-ignore-read.add b/changelog.d/noninteractive-ignore-read.add new file mode 100644 index 0000000000..5e8710cf02 --- /dev/null +++ b/changelog.d/noninteractive-ignore-read.add @@ -0,0 +1 @@ +Added option to treat non-interactive notifications (likes, repeats et all) as seen for visual purposes (no read mark, ignored in counters, still can show in native notifications) diff --git a/changelog.d/notification-read.add b/changelog.d/notification-read.add new file mode 100644 index 0000000000..e5027a954a --- /dev/null +++ b/changelog.d/notification-read.add @@ -0,0 +1 @@ +Interacting (opening reply box etc) or simply clicking on non-interactive notifications now marks them as read. Clicking on native notifications for non-interactive ones also marks them as seen. diff --git a/changelog.d/notifications-sorting.change b/changelog.d/notifications-sorting.change new file mode 100644 index 0000000000..3a61624418 --- /dev/null +++ b/changelog.d/notifications-sorting.change @@ -0,0 +1 @@ +Notifications are no longer sorted by "seen" status since interacting with them can change their read status and makes UI jumpy. Old behavior can be restored in settings. diff --git a/changelog.d/serviceworkers.change b/changelog.d/serviceworkers.change new file mode 100644 index 0000000000..b3b64f6d88 --- /dev/null +++ b/changelog.d/serviceworkers.change @@ -0,0 +1 @@ +Notifications are now shown through a serviceworker (since mobile chrome does not allow them otherwise), it's always enabled, even if previously we only enabled it for WebPush notifications only. If you don't like websites "running" while closed, check how to disable them in your browser. Old way to show notifications will be used as a fallback but might not have all the new features. diff --git a/src/components/mobile_nav/mobile_nav.js b/src/components/mobile_nav/mobile_nav.js index 6f4e35e54e..0cd6799048 100644 --- a/src/components/mobile_nav/mobile_nav.js +++ b/src/components/mobile_nav/mobile_nav.js @@ -86,7 +86,7 @@ const MobileNav = { // make sure to mark notifs seen only when the notifs were open and not // from close-calls. this.notificationsOpen = false - if (markRead) { + if (markRead && this.closingDrawerMarksAsSeen) { this.markNotificationsAsSeen() } } @@ -122,7 +122,6 @@ const MobileNav = { this.hideConfirmLogout() }, markNotificationsAsSeen () { - // this.$refs.notifications.markAsSeen() this.$store.dispatch('markNotificationsAsSeen') }, onScroll ({ target: { scrollTop, clientHeight, scrollHeight } }) {