From 53d70a98bf9b6ceafbd962b6911cd50601dbe16c Mon Sep 17 00:00:00 2001 From: Curtis Date: Thu, 2 Jul 2020 18:32:42 +0000 Subject: [PATCH 1/2] Update compose.js to decouple spoiler from marking media as NSFW --- app/soapbox/reducers/compose.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/app/soapbox/reducers/compose.js b/app/soapbox/reducers/compose.js index d9d554d47..c2e39e866 100644 --- a/app/soapbox/reducers/compose.js +++ b/app/soapbox/reducers/compose.js @@ -114,7 +114,7 @@ function appendMedia(state, media) { map.set('resetFileKey', Math.floor((Math.random() * 0x10000))); map.set('idempotencyKey', uuid()); - if (prevSize === 0 && (state.get('default_sensitive') || state.get('spoiler'))) { + if (prevSize === 0 && state.get('default_sensitive')) { map.set('sensitive', true); } }); @@ -211,9 +211,7 @@ export default function compose(state = initialState, action) { .set('is_composing', false); case COMPOSE_SENSITIVITY_CHANGE: return state.withMutations(map => { - if (!state.get('spoiler')) { - map.set('sensitive', !state.get('sensitive')); - } + map.set('sensitive', !state.get('sensitive')); map.set('idempotencyKey', uuid()); }); @@ -222,10 +220,6 @@ export default function compose(state = initialState, action) { map.set('spoiler_text', ''); map.set('spoiler', !state.get('spoiler')); map.set('idempotencyKey', uuid()); - - if (!state.get('sensitive') && state.get('media_attachments').size >= 1) { - map.set('sensitive', true); - } }); case COMPOSE_SPOILER_TEXT_CHANGE: return state From 894cd4668f496a1daf5f3f2b2bfc7e421d6af636 Mon Sep 17 00:00:00 2001 From: Curtis Date: Thu, 2 Jul 2020 22:02:21 +0000 Subject: [PATCH 2/2] Update sensitive_button_container.js to prevent it becoming disabled when Subject line is active --- .../compose/containers/sensitive_button_container.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/soapbox/features/compose/containers/sensitive_button_container.js b/app/soapbox/features/compose/containers/sensitive_button_container.js index 3497c0009..dc98de561 100644 --- a/app/soapbox/features/compose/containers/sensitive_button_container.js +++ b/app/soapbox/features/compose/containers/sensitive_button_container.js @@ -12,7 +12,6 @@ const messages = defineMessages({ const mapStateToProps = state => ({ active: state.getIn(['compose', 'sensitive']), - disabled: state.getIn(['compose', 'spoiler']), }); const mapDispatchToProps = dispatch => ({ @@ -27,13 +26,12 @@ class SensitiveButton extends React.PureComponent { static propTypes = { active: PropTypes.bool, - disabled: PropTypes.bool, onClick: PropTypes.func.isRequired, intl: PropTypes.object.isRequired, }; render() { - const { active, disabled, onClick, intl } = this.props; + const { active, onClick, intl } = this.props; return (
@@ -43,7 +41,6 @@ class SensitiveButton extends React.PureComponent { type='checkbox' checked={active} onChange={onClick} - disabled={disabled} />