From 0877574c287fda982037bfb6e73f099e8f3caa50 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?marcin=20miko=C5=82ajczak?= Date: Tue, 3 Aug 2021 10:50:08 +0200 Subject: [PATCH] Use OrderedSet MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: marcin mikołajczak --- app/soapbox/features/status/index.js | 42 +++++++++++++--------------- 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/app/soapbox/features/status/index.js b/app/soapbox/features/status/index.js index 6809b3ba3..0a687b855 100644 --- a/app/soapbox/features/status/index.js +++ b/app/soapbox/features/status/index.js @@ -71,15 +71,13 @@ const makeMapStateToProps = () => { (_, { id }) => id, state => state.getIn(['contexts', 'inReplyTos']), ], (statusId, inReplyTos) => { - let ancestorsIds = Immutable.List(); - ancestorsIds = ancestorsIds.withMutations(mutable => { - let id = statusId; + let ancestorsIds = Immutable.OrderedSet(); + let id = statusId; - while (id) { - mutable.unshift(id); - id = inReplyTos.get(id); - } - }); + while (id) { + ancestorsIds = Immutable.OrderedSet([id]).union(ancestorsIds); + id = inReplyTos.get(id); + } return ancestorsIds; }); @@ -88,25 +86,23 @@ const makeMapStateToProps = () => { (_, { id }) => id, state => state.getIn(['contexts', 'replies']), ], (statusId, contextReplies) => { - let descendantsIds = Immutable.List(); - descendantsIds = descendantsIds.withMutations(mutable => { - const ids = [statusId]; + let descendantsIds = Immutable.OrderedSet(); + const ids = [statusId]; - while (ids.length > 0) { - let id = ids.shift(); - const replies = contextReplies.get(id); + while (ids.length > 0) { + let id = ids.shift(); + const replies = contextReplies.get(id); - if (statusId !== id) { - mutable.push(id); - } + if (statusId !== id) { + descendantsIds = descendantsIds.union([id]); + } - if (replies) { - replies.reverse().forEach(reply => { - ids.unshift(reply); - }); - } + if (replies) { + replies.reverse().forEach(reply => { + ids.unshift(reply); + }); } - }); + } return descendantsIds; });