[instagram] disable login with username&password (#756)

README.rst

@@ -196,7 +196,7 @@ Some extractors require you to provide valid login-credentials in the form of
 a username & password pair. This is necessary for
 ``pixiv``, ``nijie``, and ``seiga``
 and optional for
-``danbooru``, ``e621``, ``exhentai``, ``idolcomplex``, ``instagram``,
+``danbooru``, ``e621``, ``exhentai``, ``idolcomplex``,
 ``luscious``, ``sankaku``, ``tsumino``, and ``twitter``.
 
 You can set the necessary information in your configuration file

docs/configuration.rst

@@ -230,7 +230,6 @@ Description The username and password to use when attempting to log in to
             * ``e621``
             * ``exhentai``
             * ``idolcomplex``
-            * ``instagram``
             * ``luscious``
             * ``sankaku``
             * ``tsumino``

docs/supportedsites.rst

@@ -59,7 +59,7 @@ ImgBB                https://imgbb.com/                  Albums, individual Imag
 imgbox               https://imgbox.com/                 Galleries, individual Images
 imgth                https://imgth.com/                  Galleries
 imgur                https://imgur.com/                  |imgur-C|
-Instagram            https://www.instagram.com/          |instagram-C|                                      Optional
+Instagram            https://www.instagram.com/          |instagram-C|
 Issuu                https://issuu.com/                  Publications, User Profiles
 Jaimini's Box        https://jaiminisbox.com/reader/     Chapters, Manga
 Joyreactor           http://joyreactor.com/              Posts, Search Results, Tag Searches, User Profiles

gallery_dl/extractor/instagram.py

@@ -10,7 +10,7 @@
 """Extractors for https://www.instagram.com/"""
 
 from .common import Extractor, Message
-from .. import text, exception
+from .. import text
 from ..cache import cache
 import itertools
 import json
@@ -66,35 +66,10 @@ class InstagramExtractor(Extractor):
 
     @cache(maxage=360*24*3600, keyarg=1)
     def _login_impl(self, username, password):
-        self.log.info("Logging in as %s", username)
-
-        page = self.request(self.root + "/accounts/login/").text
-        headers = {
-            "Referer"         : self.root + "/accounts/login/",
-            "X-IG-App-ID"     : "936619743392459",
-            "X-Requested-With": "XMLHttpRequest",
-        }
-
-        response = self.request(self.root + "/web/__mid/", headers=headers)
-        headers["X-CSRFToken"] = response.cookies["csrftoken"]
-        headers["X-Instagram-AJAX"] = text.extract(
-            page, '"rollout_hash":"', '"')[0]
-
-        url = self.root + "/accounts/login/ajax/"
-        data = {
-            "username"     : username,
-            "password"     : password,
-            "queryParams"  : "{}",
-            "optIntoOneTap": "true",
-        }
-        response = self.request(url, method="POST", headers=headers, data=data)
-
-        if not response.json().get("authenticated"):
-            raise exception.AuthenticationError()
-        return {
-            key: self.session.cookies.get(key)
-            for key in ("sessionid", "mid", "csrftoken")
-        }
+        self.log.warning(
+            'Logging in with username and password is currently not possible. '
+            'Use cookies from your browser session instead.')
+        return {}
 
     def _request_graphql(self, variables, query_hash, csrf=None):
         headers = {

scripts/supportedsites.py

@@ -151,7 +151,6 @@ AUTH_MAP = {
     "flickr"     : "Optional (OAuth)",
     "idolcomplex": "Optional",
     "imgbb"      : "Optional",
-    "instagram"  : "Optional",
     "mangoxo"    : "Optional",
     "newgrounds" : "Optional",
     "nijie"      : "Required",