fix a third(!) bug in _check_cookies() (#2372)

turns out tests are worthless if you get em wrong ...
pull/2432/head
Mike Fährmann 3 years ago
parent c4cc387f7d
commit 500a479026
No known key found for this signature in database
GPG Key ID: 5680CA389D365A88

@ -373,7 +373,6 @@ class Extractor():
self.log.warning(
"Cookie '%s' will expire in less than %s hour%s",
cookie.name, hours + 1, "s" if hours else "")
continue
names.discard(cookie.name)
if not names:

@ -180,14 +180,14 @@ class TestCookieUtils(unittest.TestCase):
extr._cookiejar.set("a", "1", expires=now+100)
with mock.patch.object(log, "warning") as mw:
self.assertFalse(extr._check_cookies(("a",)))
self.assertTrue(extr._check_cookies(("a",)))
self.assertEqual(mw.call_count, 1)
self.assertEqual(mw.call_args[0], (
"Cookie '%s' will expire in less than %s hour%s", "a", 1, ""))
extr._cookiejar.set("a", "1", expires=now+100+7200)
with mock.patch.object(log, "warning") as mw:
self.assertFalse(extr._check_cookies(("a",)))
self.assertTrue(extr._check_cookies(("a",)))
self.assertEqual(mw.call_count, 1)
self.assertEqual(mw.call_args[0], (
"Cookie '%s' will expire in less than %s hour%s", "a", 3, "s"))

Loading…
Cancel
Save