Due to recent `snap info` command output changes selective-checkout no
longer can match the stable channel version, which, making it always
building stable releases even when it is being promoted to the stable
channel.
This patch fixes the problem by upgrading the part to the new version,
which now call the Snap Store API for the info instead of scraping the
`snap info gallery-dl` command's output, which should ensure stability
in the future.
Refer-to: Selective-checkout: Check out the tagged release revision if it isn't promoted to the stable channel - doc - snapcraft.io <https://forum.snapcraft.io/t/selective-checkout-check-out-the-tagged-release-revision-if-it-isnt-promoted-to-the-stable-channel/10617>
Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
Snapcraft now supports a special `core` base for modern snaps to target
on which has the same effect of using the Ubuntu 16.04 based `core` snap
in the past(it is special as the intended base snap to support Ubuntu
16.04 is rather the `core16` base snap, but it isn't ready yet).
This patch migrates the gallery-dl snap to `core` base, which allows the
user to avoid installing the additional `core18` base snap in order to
run it. It also drops the redundant stage-packages entries that was
collected by Snapcraft automatically in the first place.
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
The selective-checkout scriptlet is only used during the build step, don't let it make into the final snap.
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
The build failed due to missing `requests` build dependency, this patch
drops the unused component to build to avoid the problem.
The manpages are still built for the upcoming read-manual workaround.
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
* fixup! snap: Support official config paths via *-files confinement interfaces (#197)
* FIXME no longer applied
* Obsoleted HOME environment variable assignment
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
* snap: Migrate to selective-checkout
The selective-pull stage snap is superseded by selective-checkout, prefer the new one.
Refer-to: Selective-checkout: Check out the tagged release revision if it isn't promoted to the stable channel <https://forum.snapcraft.io/t/the-selective-pull-scriptlet-stage-snap-workaround/10389>
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
* snap: Support bash completion
Refer-to: Scriptlets <https://docs.snapcraft.io/scriptlets/4892>
Refer-to: Tab completion for snaps <https://docs.snapcraft.io/tab-completion-for-snaps/2261>
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
* snap: Implement interface connection warning in the launcher
This patch ensures that the user will be acknowledge the missing
connection to the `removable-media` interface.
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This patch adds a copy of the youtube-dl package to the snap to enable the video downloading feature.
Tested with the Twitter extractor.
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This patch re-implements the pull step that will only build
development snapshots snaps if the latest tagged release has been
promoted to the stable channel. This ensures that there's always
a revision of the stable release snap available in the edge channel
for the publisher to promote to stable as currently the build
infrastructure only supports build on code push (but not new tagged
releases) at this time.
The implementation is inspired from the snapcrafters adopted snaps workflow,
documented in the following forum topic:
The automatic build and pubish process of snaps owned by the Snapcrafters - doc - snapcraft.io
https://forum.snapcraft.io/t/autopublishing-of-snapcrafters-organizations-snaps-how/7954/2
Refer the following forum topic for a possible solution proposal of this problem:
Proposal: Allow overriding the source-tag property for an one-time build in the build infrastructure - snapcraft - snapcraft.io
https://forum.snapcraft.io/t/proposal-allow-overriding-the-source-tag-property-for-an-one-time-build-in-the-build-infrastructure/10303
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This patch implements the necessary details to package gallery-dl as a snap that can be run on a broad range of supporting GNU/Linux distributions[1].
[1] https://snapcraft.io/
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
teslaedison