mirror_maker/synapse-s3-storage-provider
1
0
Fork 1
mirror of https://github.com/matrix-org/synapse-s3-storage-provider.git synced 2024-10-23 07:29:40 +00:00
Code Issues Projects Releases Packages Wiki Activity

Use boto3 session from localdata.

Browse source 
This prevents issues when the thread-unsafe Session() is
used by multiple threads by allocating one in local_data.
This commit is contained in:
Michael Kaye 2019-06-06 09:57:49 +01:00
parent ad284721a0
commit b0c94ff56e
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
s3_storage_provider.py
View file

@ -141,7 +141,10 @@ class _S3DownloadThread(threading.Thread):
self.deferred = deferred self.deferred = deferred
def run(self): def run(self):
session = boto3.session.Session() local_data = threading.local()
if not hasattr(local_data, "b3_session"):
local_data.b3_session = boto3.session.Session()
session = local_data.b3_session
s3 = session.client('s3', **self.api_kwargs) s3 = session.client('s3', **self.api_kwargs)
try: try: