use Last-Modified header to set file modification time

(#236, #277)

gallery_dl/downloader/http.py

@@ -151,6 +151,9 @@ class HttpDownloader(DownloaderBase):
         self.downloading = False
         if adj_ext:
             pathfmt.set_extension(adj_ext)
+        filetime = response.headers.get("Last-Modified")
+        if filetime:
+            pathfmt.keywords["_filetime"] = filetime
         return True
 
     def receive(self, response, file):

gallery_dl/util.py

@@ -12,6 +12,7 @@ import re
 import os
 import sys
 import json
+import time
 import shutil
 import string
 import _string
@@ -19,6 +20,7 @@ import sqlite3
 import datetime
 import operator
 import itertools
+import email.utils
 import urllib.parse
 from . import text, exception
 
@@ -613,17 +615,23 @@ class PathFormat():
             os.unlink(self.temppath)
             return
 
-        if self.temppath == self.realpath:
+        if self.temppath != self.realpath:
-            return
+            # move temp file to its actual location
-
+            try:
-        try:
+                os.replace(self.temppath, self.realpath)
-            os.replace(self.temppath, self.realpath)
+            except OSError:
-            return
+                shutil.copyfile(self.temppath, self.realpath)
-        except OSError:
+                os.unlink(self.temppath)
-            pass
 
-        shutil.copyfile(self.temppath, self.realpath)
+        if "_filetime" in self.keywords:
-        os.unlink(self.temppath)
+            # try to set file times
+            try:
+                filetime = email.utils.mktime_tz(email.utils.parsedate_tz(
+                    self.keywords["_filetime"]))
+                if filetime:
+                    os.utime(self.realpath, (time.time(), filetime))
+            except Exception:
+                pass
 
     @staticmethod
     def adjust_path(path):