Merge branch 'remove-groups-search' into 'develop'

Remove group search inside global search

See merge request soapbox-pub/soapbox!2499

app/soapbox/actions/search.ts

@@ -1,7 +1,7 @@
 import api from '../api';
 
 import { fetchRelationships } from './accounts';
-import { importFetchedAccounts, importFetchedGroups, importFetchedStatuses } from './importer';
+import { importFetchedAccounts, importFetchedStatuses } from './importer';
 
 import type { AxiosError } from 'axios';
 import type { SearchFilter } from 'soapbox/reducers/search';
@@ -83,10 +83,6 @@ const submitSearch = (filter?: SearchFilter) =>
         dispatch(importFetchedStatuses(response.data.statuses));
       }
 
-      if (response.data.groups) {
-        dispatch(importFetchedGroups(response.data.groups));
-      }
-
       dispatch(fetchSearchSuccess(response.data, value, type));
       dispatch(fetchRelationships(response.data.accounts.map((item: APIEntity) => item.id)));
     }).catch(error => {
@@ -143,10 +139,6 @@ const expandSearch = (type: SearchFilter) => (dispatch: AppDispatch, getState: (
       dispatch(importFetchedStatuses(data.statuses));
     }
 
-    if (data.groups) {
-      dispatch(importFetchedGroups(data.groups));
-    }
-
     dispatch(expandSearchSuccess(data, value, type));
     dispatch(fetchRelationships(data.accounts.map((item: APIEntity) => item.id)));
   }).catch(error => {

app/soapbox/containers/group-container.tsx

@@ -1,24 +0,0 @@
-import React, { useCallback } from 'react';
-
-import GroupCard from 'soapbox/components/group-card';
-import { useAppSelector } from 'soapbox/hooks';
-import { makeGetGroup } from 'soapbox/selectors';
-
-interface IGroupContainer {
-  id: string
-}
-
-const GroupContainer: React.FC<IGroupContainer> = (props) => {
-  const { id, ...rest } = props;
-
-  const getGroup = useCallback(makeGetGroup(), []);
-  const group = useAppSelector(state => getGroup(state, id));
-
-  if (group) {
-    return <GroupCard group={group} {...rest} />;
-  } else {
-    return null;
-  }
-};
-
-export default GroupContainer;

app/soapbox/features/compose/components/search-results.tsx

@@ -9,13 +9,11 @@ import IconButton from 'soapbox/components/icon-button';
 import ScrollableList from 'soapbox/components/scrollable-list';
 import { HStack, Tabs, Text } from 'soapbox/components/ui';
 import AccountContainer from 'soapbox/containers/account-container';
-import GroupContainer from 'soapbox/containers/group-container';
 import StatusContainer from 'soapbox/containers/status-container';
 import PlaceholderAccount from 'soapbox/features/placeholder/components/placeholder-account';
-import PlaceholderGroupCard from 'soapbox/features/placeholder/components/placeholder-group-card';
 import PlaceholderHashtag from 'soapbox/features/placeholder/components/placeholder-hashtag';
 import PlaceholderStatus from 'soapbox/features/placeholder/components/placeholder-status';
-import { useAppDispatch, useAppSelector, useFeatures } from 'soapbox/hooks';
+import { useAppDispatch, useAppSelector } from 'soapbox/hooks';
 
 import type { OrderedSet as ImmutableOrderedSet } from 'immutable';
 import type { VirtuosoHandle } from 'react-virtuoso';
@@ -24,7 +22,6 @@ import type { SearchFilter } from 'soapbox/reducers/search';
 const messages = defineMessages({
   accounts: { id: 'search_results.accounts', defaultMessage: 'People' },
   statuses: { id: 'search_results.statuses', defaultMessage: 'Posts' },
-  groups: { id: 'search_results.groups', defaultMessage: 'Groups' },
   hashtags: { id: 'search_results.hashtags', defaultMessage: 'Hashtags' },
 });
 
@@ -33,7 +30,6 @@ const SearchResults = () => {
 
   const intl = useIntl();
   const dispatch = useAppDispatch();
-  const features = useFeatures();
 
   const value = useAppSelector((state) => state.search.submittedValue);
   const results = useAppSelector((state) => state.search.results);
@@ -66,14 +62,6 @@ const SearchResults = () => {
       },
     );
 
-    if (features.groups) items.push(
-      {
-        text: intl.formatMessage(messages.groups),
-        action: () => selectFilter('groups'),
-        name: 'groups',
-      },
-    );
-
     items.push(
       {
         text: intl.formatMessage(messages.hashtags),
@@ -186,31 +174,6 @@ const SearchResults = () => {
     }
   }
 
-  if (selectedFilter === 'groups') {
-    hasMore = results.groupsHasMore;
-    loaded = results.groupsLoaded;
-    placeholderComponent = PlaceholderGroupCard;
-
-    if (results.groups && results.groups.size > 0) {
-      searchResults = results.groups.map((groupId: string) => (
-        <GroupContainer id={groupId} />
-      ));
-      resultsIds = results.groups;
-    } else if (!submitted && trendingStatuses && !trendingStatuses.isEmpty()) {
-      searchResults = null;
-    } else if (loaded) {
-      noResultsMessage = (
-        <div className='empty-column-indicator'>
-          <FormattedMessage
-            id='empty_column.search.groups'
-            defaultMessage='There are no groups results for "{term}"'
-            values={{ term: value }}
-          />
-        </div>
-      );
-    }
-  }
-
   if (selectedFilter === 'hashtags') {
     hasMore = results.hashtagsHasMore;
     loaded = results.hashtagsLoaded;

app/soapbox/locales/en.json

@@ -689,7 +689,6 @@
   "empty_column.remote": "There is nothing here! Manually follow users from {instance} to fill it up.",
   "empty_column.scheduled_statuses": "You don't have any scheduled statuses yet. When you add one, it will show up here.",
   "empty_column.search.accounts": "There are no people results for \"{term}\"",
-  "empty_column.search.groups": "There are no groups results for \"{term}\"",
   "empty_column.search.hashtags": "There are no hashtags results for \"{term}\"",
   "empty_column.search.statuses": "There are no posts results for \"{term}\"",
   "empty_column.test": "The test timeline is empty.",
@@ -1320,7 +1319,6 @@
   "search.placeholder": "Search",
   "search_results.accounts": "People",
   "search_results.filter_message": "You are searching for posts from @{acct}.",
-  "search_results.groups": "Groups",
   "search_results.hashtags": "Hashtags",
   "search_results.statuses": "Posts",
   "security.codes.fail": "Failed to fetch backup codes",